feat: oidc provenance by default #8412
Merged
+372
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reggi
force-pushed
the
oidc-default-provenance
branch
from
197c641 to
7476f21
Compare
reggi
force-pushed
the
oidc-default-provenance
branch
from
7476f21 to
f55cce1
Compare
reggi
changed the title
reggi
commented
Jul 9, 2025
| @@ -205,7 +205,7 @@ const ensureProvenanceGeneration = async (registry, spec, opts) => { | |||
| if (opts.access !== 'public') { | |||
| try { | |||
| const res = await npmFetch | |||
| .json(`${registry}/-/package/${spec.escapedName}/visibility`, opts) | |||
There was a problem hiding this comment.
this has been making a double path slash call, // because registry domain ends with / and the path has it too, this was unintuitive to keep when nocking properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "auto" or "default" provenance to publishes that use OIDC within github and gitlab. It does this by checking the OIDC id token payload and checking if the current repo's visibility is public or private if it's public we do the equivalent of adding the
--provenanceflag.